Repository navigation
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 14, 2026 13:47
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Contributor
|
This looks better and will most likely irritate my agent less. Thanks evan! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A check that failed when linked issues were not accepted was found to be quite verbose and caused confusition with submitters even though the check was not required.
For this reason, this PR removes the check that checks whether linked issues are all accepted. The additions to the review skills to call out unaccepted issues from #4340 are still kept. This should call this out when reviewing PRs.
Related Issue
No issue required: this is a localized CI maintenance change requested directly by a repository administrator, who explicitly requested no new issue.
Changes
Testing
mise run pre-commitpasses.git diff --checkpasses.mise run ciattempted; Rust test linking fails because the local linker cannot find the Z3 library (ld: library 'z3' not found).Checklist